Zugg Software :: View topic

Beginner Joined: 12 Aug 2003 Posts: 14

I have a few questions regarding data record variables. First is concerning this bit of code

Beginner Joined: 12 Aug 2003 Posts: 14

I was running the first loop in debug and noticed that its looping each individual record 17 times in both variables. 2 vars, 18 values in each, 17 loops on each one, thats 612 loops! I cannot explain why that should be happening...

MASTER Joined: 28 Nov 2000 Posts: 4817 Location: USA

To start with, you don't need @SprigCheck. You can use the numbers from @Sprigcount instead. Also, since it appears your multi-word sprigs can all be identified from the first word you can further simplify by simply using that as your key.

I assumed the second script was all supposed to be part of the alias. The way you posted it, the alias just sets two variables.

You're running a #LOOP inside your #LOOPDB. This appears to be unintentional, since it looks like you want to go through the entire herblist before you begin mixing. I moved it outside and changed it to #REPEAT. I made numerous other changes either to simplify or simply to suit my own preferences. [:p]

If you decide to use this, be sure to change the keys in @SprigCount and @SprigPower (first word in the sprig's name).

#TR {(%d)~) a sprig of (%w)} {
#IF %iskey(@SprigCount, %2) {#ADDK SprigCount %2 %1}
}

#AL herb {
#VAR mixnum %1
#VAR mixtype %2
#VAR mixpower 0
#VAR remainder @max
#LOOPDB @SprigPower {
#IF ((%val <= @remainder) AND (@SprigCount.%key >= @mixnum)) {
#ADD mixpower %val
#ADDI final {get %key @herbbag}
#ADDI herblist %key
#ADD remainder -%val
}}
#IF ((@MixMin.@mixtype <= @mixpower) AND (@mixpower <= @MixMax.@mixtype)) {
#REPEAT @mixnum {
#EXEC %expandlist( @final, ";")
mix %expandlist( @herblist, " ")
}}}

Beginner Joined: 12 Aug 2003 Posts: 14

Thanks, thats much better, but there's a glitch. In the first conditional the %key of SprigCount is the name of the herb, not the number of herbs, which is the value. Calling %val there would return the %val for SprigPower wouldn't it? Not sure how to fix that without resorting to a big cumbersome list of single variables for each value in count...

MASTER Joined: 28 Nov 2000 Posts: 4817 Location: USA

The %key is from SprigPower, not SprigCount. The glitch is in @varname.key, the shortcut form of %db. The fix is to use %db.
Replace
#IF ((%val <= @remainder) AND (@SprigCount.%key >= @mixnum)) {
with
#IF ((%val <= @remainder) AND (%db( @SprigCount, %key) >= @mixnum)) {

Beginner Joined: 12 Aug 2003 Posts: 14

MASTER Joined: 28 Nov 2000 Posts: 4817 Location: USA

From what you say, you first noticed zMUD slowing down while you were using this alias. But you then go on to say that it REMAINED slow even after rebooting and using settings files which DON'T contain this alias. Nonetheless, you seem to think that it's this alias which is at fault. That seems extremely unlikely.

This alias doesn't contain anything which should make zMUD particularly slow. If it did, any slowdown it caused would end when the alias reached its end. It would certainly end when you rebooted the computer. Nor is there any capability for any zMUD setting to load itself into memory without being included in one of the settings files zMUD loads for a character. It's far more likely that something else is the cause of the slowdown, and it's just coincidence that this alias happened to be running when you noticed it.

On a side note, you don't need your first loop
#LOOPDB @SprigCount {#VAR SprigCount.%key {0}}
since you already know the names of all your herbs. Just set them to 0 in a direct statement.
#ADDKEY SprigCount {lingua|virga|sedum} 0
(those are the only three names you've allowed to slip out)

Beginner Joined: 12 Aug 2003 Posts: 14

You're right of course, I don't know what the cause of it is but maybe reinstalling will clear it up. Thanks for all the help Lightbulb, you're a zmud jedi in my book Wink

Beginner Joined: 12 Aug 2003 Posts: 14

And I spoke too soon about the whole "it works" thing [:p]

#VAR remainder {@MixMax.@mixtype} isnt working properly, because mixmax expands first and sets remainder to be a data record with the same values as mixmax with only the text held by mixtype stuck in at the end. I think if @mixtype expanded first it would work perfectly. Its pretty likely the other occurences of @variable.@othervariable will do the same thing.

Help me obi wan, you're my only hope :>

MASTER Joined: 28 Nov 2000 Posts: 4817 Location: USA

%db( @MixMax, @mixtype)

Beginner Joined: 12 Aug 2003 Posts: 14

This is the script that refuses to work, for every problem solved a new one arises. Now I've noticed an issue with this piece
(%db( @SprigCount, %key)
within the #loopdb command. It returns nothing. I tested it from every angle I could think of and it just doesnt return a thing. I don't know if its because its a db inside a db or what, but if you've got another shot at this one Mr. Wizard I'd be grateful.

MASTER Joined: 28 Nov 2000 Posts: 4817 Location: USA

Actually it's %db( @SprigCount, %key). Or, it could be (%db( @SprigCount, %key) >= @mixnum).

I don't know how you tested it. I tested it by putting numbers into @remainder and @mixnum, and name-number pairs into @SprigPower and @SprigCount, then running a #LOOPDB which gave me different responses for true and false. It works fine.