Zugg Software :: View topic

Wizard Joined: 22 Mar 2007 Posts: 2320

Is that the entire trigger? This code isn't using @XP, so I suspect it is not. I don't see anything
obiously wrong with that particular line, but I don't have Cmud on this machine to check whether
it compiles. What makes you think that line is the problem?

It might be best to give the entire trigger so we can see the entire thing. The best way to do
it is to click the XML tab at the bottom of the Package Editor and cut and paste all of the XML.

Wanderer Joined: 24 Aug 2012 Posts: 70

@XP is used on a statusbar, but It wasn't the trigger line that was an issue. It worked fine when I just had that #LOOP. It started this when I added the #IF to get rid of the EXAMINE 1.CORPSE.

Wanderer Joined: 24 Aug 2012 Posts: 70

It even shows this in the package editor under the compiled code tab...

Wanderer Joined: 24 Aug 2012 Posts: 70

Figured it out. The #LOOP 1, @counter was the issue. Seems the variable got moved over a space. #LOOP 1,@counter works.

Posted: Thu Sep 13, 2012 12:43 am

Since #LOOP 1,1 {...} does nothing, there is no need to check. If you are going to check at all, check to make sure @counter is not less than 1.

Sorcerer Joined: 15 Apr 2011 Posts: 809

Huh? That makes no sense. First of all, #LOOP 1,1 {...} doesn't do nothing, it loops once with 1 as %i, and second, your code doesn't make sure @counter is not less than 1, it just checks that it's not zero. There's nothing wrong with his code (except the fixed syntax error, of course).

Wanderer Joined: 12 Feb 2003 Posts: 93 Location: USA

Meddlesome, the #LOOP 1, @counter with a space should work. I use it that way constantly.

Sorcerer Joined: 15 Apr 2011 Posts: 809

#LOOP cannot have a space between the range values. Just a simple "#LOOP 1, 10 {}" is enough to prove that - enter it on your command line and you'll see you get an error. The {} is required to have the dot act as a literal rather than the member of operator. %i.CORPSE would look for the CORPSE key in the %i database variable and return the value, which would obviously always be null since %i will always just be a number. Personally, I would write it like this:

Wanderer Joined: 12 Feb 2003 Posts: 93 Location: USA

Perhaps the %i isn't checking the database because I do not have one loaded? but I can run for example
#loop 1,5 {examine %i.corpse}

and get
examine 1.corpse
examine 2.corpse
examine 3.corpse
examine 4.corpse
examine 5.corpse

I guess it is good to know for the future.. as I'm debating using the DB.

Sorcerer Joined: 15 Apr 2011 Posts: 809

I'm talking about normal key=value pair database variables, not the database module. The var.key syntax was added early in v3, if you're still using 2.37 you wouldn't have this issue.