Zugg Software :: View topic

Wanderer Joined: 03 Oct 2007 Posts: 66

Random Dir Script conversion from Zmud to Cmud for a random zone. It works in cmud but it keeps going back and forth from the same room to the other over and over again.

Trigger:^(*)~[ Exits:(*)~]$
Value:
#VAR ExitsStr {%2}
#VAR ArrayExits {%replace( @ExitsStr, ' ', '|')}
#var TotalDirs %numitems( @ArrayExits)
#if (@AutoRunner=1) {
#var Mobs 0
#var NewRoom 1
#T+ @Place
#var GetRusted 1
}
#if (@AutoNim=1) {
#var Mobs 0
#var NewRoom 1
#T+ @Place
}
#if (@AutoAbyss=1) {
#var Mobs 0
#var NewRoom 1
#T+ @Place
#if @NimDir=up) {
#var ArrayExits %delitem( down, @ArrayExits)
#ADD TotalDirs -1
}
#if @NimDir=down) {
#var ArrayExits %delitem( up, @ArrayExits)
#ADD TotalDirs -1
}
#if @NimDir=east) {
#var ArrayExits %delitem( west, @ArrayExits)
#ADD TotalDirs -1
}
#if @NimDir=west) {
#var ArrayExits %delitem( east, @ArrayExits)
#ADD TotalDirs -1
}
#if @NimDir=south) {
#var ArrayExits %delitem( north, @ArrayExits)
#ADD TotalDirs -1
}
#if @NimDir=north) {
#var ArrayExits %delitem( south, @ArrayExits)
#ADD TotalDirs -1
}
#if (@TotalDirs=0) {#var NimDir @PrevNimDir}
}

Trigger: ^~[Rep:*~]~[Gold:(%d)~]~[xp:(%n)~]~[(%n)~] ~[*~]->$
Value
#if (@AutoNim=1) {#if (@NewRoom=1) {
#var NewRoom 0
#if (@Total_mobs=0) {godir}
#if (@Total_mobs>0) {
#var target %item( @Mob_Array, 1)
gg
}
}}
#if (@AutoAbyss=1) {
#if (%2=1000000000) {halt}
#if (@NewRoom=1) {
#var NimDir %item( @ArrayExits, %random( 1, @TotalDirs))
#var NewRoom 0
#if (@Total_mobs=0) {
@nimdir
#var Mob-Array {}
}
#if (@Total_mobs>0) {
#var target %item( @Mob_Array, 1)
gg
}
}
}

In one of those trigs somewhere it is messing it up and I am at a complete loss.
Edit: I also had it so it would remove the last direction when it randoms the direction again so I wouldn't repeat rooms... Doesn't do that in cmud

Posted: Sat Jun 30, 2012 7:33 am

A few things to mention:

1. Please, whenever posting code, put it between [code][/code] tags (e.g. [code]<put code here>[/code]). It makes it slightly easier to read. Even better is if you right-click the trigger in CMUD, choose copy, then paste that info between the code tags. That way we can just copy/paste into our own CMUD.

2. You don't need to capture everything, especially if you're not using it. Your first trigger, you can remove the () around the first *. You're not using it in the value at all.

3. You don't need to name a variable to something you're using within the code and won't use elsewhere. In your first trigger, you create (or update a variable) called ExitStr. You don't seem to use it anywhere else, so that line isn't needed at all.

4. Instead of using %replace(%1, ' ', '|'), you can use %list(%1," ").

5. You don't need to do var=1 or var>0 if you're checking for true/false. Doing #IF (@var) {true} {false} will return true each time @var is not equal to 0. Doing #IF (!@var) {true} {false} will return true each time @var IS equal to 0.

6. You really should have double quotes around strings so CMUD knows it's nothing other than a string. Things like #IF (@NimDir=up) should be #IF (@NimDir="up") Please note this does not apply to numbers.

7. If you have multiple #IFs and you're doing at least one thing the same in each, you don't have to process it for each #IF. If you put it at the end of the multiple #IFs, it'll process properly. Example:

Wanderer Joined: 03 Oct 2007 Posts: 66

Thank you and sorry it is so messy and confusing. This is just stuff I learned on my own, as a kid, and 10+ years later I'm now asking for help because I converted to cmud. I must look like a savage which was raised by scripting wolves lol. ^.^

Wanderer Joined: 03 Oct 2007 Posts: 66

Ok, I got the list working and the #switch working so thank you very much. It is now correctly loading the dirs into the script and randomly choosing one to move onto the next part. What is messed up now is that I used to use this %of wjem there were no mobs so I hope I pasted this correct this time.

Wanderer Joined: 03 Oct 2007 Posts: 66

Posted: Sat Jun 30, 2012 4:10 pm

As I mentioned in point 9 (though I should have worded it better), CMUD does not understand what to do when a line starts with a function or a variable. In the case of the %if function, you need to change it to:

Wanderer Joined: 03 Oct 2007 Posts: 66

Ok, I got it almost working now but the nimdir sometimes doesn't load properly (and has no value) and sometimes it does load properly. I am not sure why though and if I just type look again it loads it and works.. I believe this would be because of my exit or reply triggers? Let me know if anyone sees what is going wrong and I'm sorry I am not as good as this as you guys. You are all a huge help though. I also noticed totaldirs isn't adding right. I have The Abyss [ exits: north east south west down ] and it adds 6 to totaldirs not 5

Wanderer Joined: 03 Oct 2007 Posts: 66

Hmmm, so I noticed when it moves to a room with 3 exits it sets totaldirs as 4. Now it should be 2 totals dirs because 3 -1 (prevdir so I don't backtrack in my random dir zone) should be 2 not 4. So, if it then randomly chooses from 4 then 2 of those would be dirs that don't exist right? I'm thinking that is what isn't working right maybe... I don't know... it all worked perfectly in zmud lol but I love cmud now =/

Wanderer Joined: 03 Oct 2007 Posts: 66

anyone? Also, if anyone has the time (probably an hour or less) and wants to assist with this on an IM program or Vent just PM me. My friend and I have been working on it all day and it seems the nimdir is adding too much to its value and not the correct amount of exits. We can't figure it out for the life of us. =/

Posted: Sun Jul 01, 2012 12:46 am

Where are you originally defining @NimDir? That doesn't appear to be listed anywhere here. Also, you might consider adding #PRINT {@NimDir} as debugging to see what's actually being stored.

Wanderer Joined: 03 Oct 2007 Posts: 66

Yup, we did that and figured out the problem and can't find a solution so here it is!

lets say there are three rooms. it is assigning those 3 rooms to an array (arrayexits) but adds two more null values (when we check arrayexits it will have 1 (nothing 2 south 3 north 4 nothing and so forth. it seems when it randomly assigns arrayexits to nimdir it sometimes chooses that null value from arrayexits. to answer your questions arrayexits is assigned to nimdir here

Posted: Sun Jul 01, 2012 1:17 am

I think I see your problem.

I'm going to guess that your exits line looks like this:

Wanderer Joined: 03 Oct 2007 Posts: 66

THANK YOU SO MUCH!!! IT WORKS!

Wizard Joined: 22 Mar 2007 Posts: 2320

Alternatively, you could use the %trim() function to get rid of all leading and trailing spaces, or change