Zugg Software :: View topic

Beginner Joined: 22 Sep 2010 Posts: 12

I been making this autohealing trigger for myself and my tank firing of my prompt
and it seems to be very unreliable in getting enabled again and often it is disabled witout even having healed
Had to put in the trigger disabling or else i would often spam 10 heals where only 1 was needed in combat
The actual prompt this fires of looks like this the space in front included
the L:is leaders current hp and the H: is my current hp
L:878 H:730 M:1007 V:367>
all of these triggers are pattern triggers

pattern1
^ L:(%1) H:(%2)
#if (@tankfull > %1) {cast 'full heal' @tank}
#if (@tankheal > %1) {cast 'heal' @tank}
#if (@selffull > %2) {cast 'full heal' @self}
#if (@selfheal > %2) {cast 'heal' @self}
#t- healing

pattern2
^You heal
#t+ healing

pattern3
^You fully heal
#t+ healing

if anyone can tell me what i done wrong or have a smarter solution alltogheter it would be much appriciated

Wizard Joined: 26 Mar 2008 Posts: 1547

I wouldn't make it fire off of your prompt, personally. What are some indicators that your tank has taken damage? aka if I can get some examples of some battlespam I can probably make a decent script for you.

Beginner Joined: 22 Sep 2010 Posts: 12

Here is a little sample of 1 small fight

A Statue has arrived from the west.
A Statue sees Scary, and attacks!
Scary dodges A Statue's blow.
A Statue bruises Scary with his hit.

L:1125 H:730 M:868 V:367>
Scary wipes his boots in the face of A Statue!

L:1125 H:730 M:868 V:367> You crush A Statue very hard.

L:1125 H:730 M:868 V:367>
A Statue hits Scary hard.
A Statue hits Scary hard.
A Statue hits Scary very hard.
Scary parries A Statue's attack.
A Statue bruises Scary with his hit.
Scary dodges A Statue's blow.
A Statue bruises Scary with his hit.
A Statue hits Scary very hard.
Scary massacres A Statue with his stab.
Scary maims A Statue with a critical hit.
Scary massacres A Statue with his stab.
Scary maims A Statue with a critical hit.
Scary massacres A Statue with his stab.
Scary devastates A Statue with his triple damage attack.
Scary demolishes A Statue with a horrific stab!
You bruise A Statue as you crush him.

L:1030 H:730 M:873 V:367>
A Statue hits Scary hard.
A Statue hits Scary hard.
Scary parries A Statue's attack.
A Statue maims Scary with a critical hit.
A Statue bruises Scary with his hit.
Scary parries A Statue's attack.
A Statue bruises Scary with his hit.
A Statue hits Scary very hard.
Scary parries A Statue's attack.
A Statue bruises Scary with his hit.
Scary massacres A Statue with his stab.
Scary massacres A Statue with his stab.
Scary stabs A Statue extremely well.
Scary maims A Statue with his double damage attack.
Scary pulverizes A Statue with an amazing stab.
You crush A Statue very hard.
The white glow around A Statue's body fades.
You injure A Statue with a critical hit.
You pulverize A Statue with your amazing crush.

L:959 H:730 M:878 V:367>
Scary misses a kick at A Statue's groin.

L:959 H:730 M:878 V:367>
A Statue hits Scary very hard.
Scary parries A Statue's attack.
A Statue bruises Scary with his hit.
A Statue maims Scary with a critical hit.
A Statue hits Scary very hard.
A Statue hits Scary hard.
A Statue hits Scary hard.
Scary dodges A Statue's blow.
A Statue bruises Scary with his hit.
Scary pulverizes A Statue with an amazing stab.
Scary pulverizes A Statue with an amazing stab.
Scary pulverizes A Statue with an amazing stab.
You massacre A Statue with your crush.
You maim A Statue with your double damage attack.
You demolish A Statue with your horrific crush!

L:858 H:730 M:883 V:367>
A Statue hits Scary hard.
A Statue maims Scary with his double damage attack.
A Statue massacres Scary with his hit.
Scary dodges A Statue's blow.
A Statue bruises Scary with his hit.
A Statue hits Scary hard.
A Statue hits Scary very hard.
A Statue hits Scary hard.
Scary maims A Statue with a critical hit.
Scary demolishes A Statue with a horrific stab!
Scary maims A Statue with a critical hit.
Scary demolishes A Statue with a horrific stab!
Scary pulverizes A Statue with an amazing stab.
Scary pulverizes A Statue with an amazing stab.
You massacre A Statue with your crush.
You massacre A Statue with your crush.

L:724 H:730 M:888 V:367>
Scary makes a nice balletstep which plants a foot a mile above A Statue's head.

L:724 H:730 M:888 V:367>
A Statue hits Scary very hard.
A Statue hits Scary extremely well.
Scary parries A Statue's attack.
A Statue bruises Scary with his hit.
A Statue maims Scary with a critical hit.
A Statue hits Scary extremely well.
A Statue bruises Scary with his hit.
Scary dodges A Statue's blow.
A Statue bruises Scary with his hit.
Scary pulverizes A Statue with an amazing stab.
Scary pulverizes A Statue with an amazing stab.
You massacre A Statue with your crush.
You miss A Statue.

L:628 H:730 M:893 V:367>
Scary parries A Statue's attack.
A Statue bruises Scary with his hit.
A Statue hits Scary very hard.
A Statue hits Scary hard.
A Statue maims Scary with his double damage attack.
A Statue massacres Scary with his hit.
Scary dodges A Statue's blow.
A Statue bruises Scary with his hit.
A Statue hits Scary hard.
Scary pulverizes A Statue with an amazing stab.
Scary pulverizes A Statue with an amazing stab.
Scary maims A Statue with a critical hit.
Scary demolishes A Statue with a horrific stab!
You massacre A Statue with your crush.
You massacre A Statue with your crush.

L:507 H:730 M:898 V:367>
Scary misses a kick at A Statue's groin.

L:507 H:730 M:898 V:367>
A Statue hits Scary hard.
Scary parries A Statue's attack.
A Statue maims Scary with a critical hit.
A Statue bruises Scary with his hit.
A Statue hits Scary hard.
Scary dodges A Statue's blow.
A Statue bruises Scary with his hit.
Scary parries A Statue's attack.
A Statue bruises Scary with his hit.
A Statue hits Scary hard.
Scary pulverizes A Statue with an amazing stab.
Scary pulverizes A Statue with an amazing stab.
Scary pulverizes A Statue with an amazing stab.
Scary pulverizes A Statue with an amazing stab.
You massacre A Statue with your crush.
You miss A Statue.

L:442 H:730 M:903 V:367>
A Statue hits Scary hard.
Scary dodges A Statue's blow.
A Statue bruises Scary with his hit.
Scary parries A Statue's attack.
A Statue bruises Scary with his hit.
A Statue hits Scary very hard.
A Statue hits Scary hard.
A Statue hits Scary very hard.
Scary pulverizes A Statue with an amazing stab.
Scary maims A Statue with a critical hit.
Scary demolishes A Statue with a horrific stab!
A Statue is dead! R.I.P.
You gain 238620 experience.
Your blood freezes as you hear A Statue's death cry.
Scary splits 38380 coins, of which you receive 19190 of them.

Wizard Joined: 26 Mar 2008 Posts: 1547

Can I have a list of all the possible damage amounts? Just in case some weren't covered in there?

By damage amounts I mean the stuff like "maims" and "demolishes"

Beginner Joined: 22 Sep 2010 Posts: 12

err nope i dont have all that atm and also some spells/roomeffects and such looks the same even if tank have immune/resist to that dmg type
so i dont think your idea will work very good in this case

the other clerics all go off the prompt with a variable set for when they gonna heal etc but they all use some tintin variants so i cant really use their scripts

Wizard Joined: 26 Mar 2008 Posts: 1547

Trust me, it will likely work, but I'm going to need to possible damage variants in order to do so. I'll make the basic outline of the script, but without your cooperation I won't be able to finish it. I promise you though, it can be done the way I'm attempting to do it, and I'm sure it will be much more efficient and far less buggy. Gotta trust me though.

Wizard Joined: 26 Mar 2008 Posts: 1547

To explain: the basic concept is this

1. Recognize when the Tank takes damage.
- We don't care about when they dodge or they get a resist echo. We just need to isolate any echo where a tank takes damage
2. Recognize the end of a round of battle where the Tank took damage.
- Easy enough, taking damage will turn on a trigger. This trigger will turn off at the first blank-line, since the blank line signals the end of a round. Before this trigger shuts off it will toss out a heal.
3. Repeat

This means you will never toss out a heal more than once around and you will only toss out heals whenever the Tank takes damage.

Beginner Joined: 22 Sep 2010 Posts: 12

will take me some weeks to collect all that data and probably will be missing parts of it but how can it takes into accounts immunities and resist on certains effects that says you are splashed with acid and it can mean evrything from 0 dmg to 2000?

Wizard Joined: 26 Mar 2008 Posts: 1547

You don't need to take into account immunities, just damage nouns. For instance, on my mud it's:

Beginner Joined: 22 Sep 2010 Posts: 12

some roomeffects and spelleffects look the same even if the damage done can vary with several thousand points of damage so in one way or another i really need it to be based on the
value from prompt

Wizard Joined: 26 Mar 2008 Posts: 1547

I think you're misunderstanding, but if you can't get me that info then I can't help. There's a lot of problems using a prompt for triggers because of how frequently it appears, as such it does things when you don't want it to. Sometimes to come up with a reasonable solution you need to put in a bit if effort and work, it's just the way of things: my Clan Highlighter has over 1600 hundred lines of script.

Nevertheless, if you share the XML of your script I'll take a look at it and see what I can do.

Beginner Joined: 22 Sep 2010 Posts: 12

i know what you trying to say but on here we got some special rooms and spells and other effects where you dont get anything saying how much dmg you or other takes
other then reading prompt or using group command thats why i never botherd to get the actual descriptions of all of them
also the heal and full heal spells dont always heal the same amount either

<trigger name="healing" priority="810" id="81">
<pattern>^ L:(%1) H:(%2)</pattern>
<value>#if (@tankfull > %1) {cast 'full heal' @tank}
#if (@tankheal > %1) {cast 'heal' @tank}
#if (@selffull > %2) {cast 'full heal' @self}
#if (@selfheal > %2) {cast 'heal' @self}
#t- healing</value>
</trigger>

<trigger priority="870" id="87">
<pattern>^You fully heal</pattern>
<value>#t+ healing</value>
</trigger>

<trigger priority="860" id="86">
<pattern>^You heal</pattern>
<value>#t+ healing</value>
</trigger>

Wizard Joined: 26 Mar 2008 Posts: 1547

Do you want it casting heals 4 times if all the conditions are true? Otherwise you may want a switch statement if you only intend for one heal to go off at a time, that's likely what's causing most of your issues, something like:

Beginner Joined: 22 Sep 2010 Posts: 12

heal does 100-300 healing while full heal does 1k-3k but is very mana expensive
so my idea was to use full heal if it gets really low and heals otherwise

Wizard Joined: 26 Mar 2008 Posts: 1547

Well see if one of those works as you'd like. Let me know either way.

Beginner Joined: 22 Sep 2010 Posts: 12

nvm found it out

Beginner Joined: 22 Sep 2010 Posts: 12

The first one didnt work that ended up disbaling its own triggers for me
The 2nd seems to work a bit better but got a few issues will come back to them later after i tested it more throughly

Posted: Mon Sep 27, 2010 12:28 pm

ok something both of you forgot a little, is that in a pattern (%1)/(%2) is not correct, you want to use (%n) or (%d) ...

personally i would use this, alot more simple and efficent

Wizard Joined: 26 Mar 2008 Posts: 1547

I don't use zscript patterns, I prefer regex :P, thus I don't usually fix or catch problems in zscript patterns. It doesn't make my script worse, a simple pattern fix is easy.