Zugg Software :: View topic

Wanderer Joined: 03 May 2005 Posts: 72

greetings. I am trying to make a trigger that sends the new line short room description when I enter a room. Well it works most of the time but I do notice that sometimes only part of the room description is present in the varible

the trigger is

#trigger {^&*~(&*~)} {#if %ismember(%2,@badterms) {#AB} {area = %1};
#if %ismember(%2,@badterms) {#AB} {area2 = %2}}

the variable @badterms contains misc information that i dont want stored into a variable
like (hitched)
(worn)

etc

this is what it looks like when i enter a room

Rohan Lowlands(e, s, n and w)
HP:230 EP:230> ROH s

Rohan Plains(s, n and w) [e and s]
HP:230 EP:230> ROH s

Approaching Edoras(e, s, n and w) [sw and ne]

most of the the time the var @area recieves the information before the () but I notice that some words are not sent such as Lowlands in the above example. Where in the next line Rohan Plains is completly stored in @area
I feel my trigger may be to blame for this.

Wizard Joined: 22 Mar 2007 Posts: 2320

Your trigger pattern is strange. You are using the & construction, but not naming the variables. If you aren't naming the variables within the pattern, you probably shouldn't use the & construction. As a side note, since your pattern effectively starts with the * wildcard, there's no point in using the ^ pattern. The third issue I see is that you test whether %2 is in @badterms twice, when you could do it all in a single #if statement. In addition, if you don't want to do anything if the statement is true, it is much better to test for the negative of the condition. Try using this trigger instead:

Wanderer Joined: 03 May 2005 Posts: 72

thank you !. worked like a charm and condensed my trigger