Zugg Software :: View topic

Beginner Joined: 18 Nov 2007 Posts: 28

hi,all.
I need use the %roomflags to mark the rooms that have the same name but difference location on a zone. I write the followin script to do it.

Wizard Joined: 22 Mar 2007 Posts: 2320

First, I have a few tips. These are not wrong in your code, but may be easier to understand or code.
First tip: you do not need the {#noop}. The ELSE statement of #IF is optional.
Second tip: "#math $a $a+1" could be written more clearly as "$a=$a+1". The #MATH command is no longer needed for anything, but retained for backwards compatibility.
Third tip: I think you could use local variables instead of global variables for @roomschecked and @roomflags.
Fourth tip: instead of tracking the iteration of the second loop with $a, you could use %j. %i tracks the iteration of an outer loop, %j works for an inner loop, and I think %k is available for a tertiary loop.
Fifth tip: you could use a #FORALL construction instead of your second loop. That way you won't have to use "%item(@roomschecked,$a)" to find the element in the stringlist.

I see several bugs in your code. The first problem is "%roomvnum(%mapvnum(%i))". The documentation states that %roomvnum() is the same as %mapvnum(). They are identical. So, you are converting the filter number into a vnum, and then converting that into a new vnum. I think you only need "%roomvnum(%i)". Your current code is trying to change the roomflags on the wrong room numbers.

The second problem I see is that "%roomname( @roomschecked, $a)" should be "%roomname(%item(@roomschecked, $a))".

The third problem is that when you find a match, you are changing the room flags on only one room. If room 1 and 2 have identical names, you are only changing the flag on room 2.

I hope that helps you!

[edited] fixed $item to %item

Wizard Joined: 15 Jan 2002 Posts: 1644 Location: USA

Also if you are not running this script in map mode it will not work unless you toggle %maplocked()

Wizard Joined: 22 Mar 2007 Posts: 2320

Actually, I just reexamined the logic for incrementing the room flags. As you have it currently set up, here is what happens if you have rooms 1 through 4 all with the same name, as it tests each room:
room(1) matches room(1), so roomflag(1) becomes 1. Note that this means every room will be flagged with at least a value of 1!
room(2) matches 1 and 2, so roomflag(1)=2, roomflag(2)=1
...

End result: roomflag(1)=4, roomflag(2)=3, roomflag(3)=2,roomflag(4)=1.

I don't think this is what you intended. I can think of three possible things you might have meant to do:
(A) every roomflag equal the number of rooms which match this room name, not counting this room
(B) every roomflag equal the number of rooms which match this room name, counting this room
(C) every roomflag be 1 or greater (TRUE) if there are duplicate room names, or 0 or blank (FALSE) if the room name is unique in the zone

If you need help creating a code logic for whichever of these you meant, just let us know which one you want.

Beginner Joined: 18 Nov 2007 Posts: 28

Wizard Joined: 22 Mar 2007 Posts: 2320

Interesting. So you do in fact want different values there. That didn't occur to me. Very Happy

I guess this is to distinguish rooms with identical names from each other (but why not just use the vnum?). In that case, you can ignore Problem 3 in my first posting--your logic does just fine inserting differing numbers. See whether fixing problems 1 and 2 makes it work for you.

Beginner Joined: 18 Nov 2007 Posts: 28

Wizard Joined: 22 Mar 2007 Posts: 2320

You are using #FORALL now. That means that %j will be the actual element of the stringlist, not the position of the element. When you added elements to @roomschecked, the element you put in was the vnum. Replace all instances of %roomvnum(%j) with %j.