Zugg Software :: View topic

Enchanter Joined: 10 Oct 2000 Posts: 656 Location: USA

I have not been mudding in a long time, but recently decided to try to get back into it.

I loaded cmud and upgraded all my old scripts, but many of them no longer work/compile.

This one I cannot figure out what the problem is.

trigger pattern:
~* You think your%s({@SkillChecks/SkillListing})%sskill has improved. ~*$

script:
#PRIORITY {
#VARIABLE SkillIncreased {%1} {_nodef} {SkillChecks}
#VARIABLE OriginalSkillIncreased {%1} {_nodef} {SkillChecks}
#VARIABLE SkillIncreased {%replace( %replace( %replace( %replace( @SkillChecks/SkillIncreased, " ", "_"), "'", "_"), "-", "_"), "#", "_")} {_nodef} {SkillChecks}
#VAR @SkillChecks/SkillIncreased %eval(@{SkillChecks/SkillCountVariables/@SkillChecks/SkillIncreased}+1) {_nodef} {SkillChecks|SkillCountVariables}
#IF (@SkillChecks/PlussOn=1) {
#IF (@MagicWork/QueuedCommands/RecordQc=0) {
show skills @OriginalSkillIncreased
say + @OriginalSkillIncreased
} {
Qc show skills @OriginalSkillIncreased
Qc say + @OriginalSkillIncreased
}
}
#COLOR 11
update_time
}

test pattern:
* You think your teaching skill has improved. *

Compile Code says there is a missing bracket, but there is not.

Also this line used to be in the script, but it appearently is not working either.
:skills:#sh @OriginalSkillIncreased @{@OriginalSkillIncreased}

was suppose to write to a window the skill name and the point value.

oh, and hello again zugg, been a long time. I used to be very active on your boards up to about 1 1/2 years ago when I gave up mudding.

Enchanter Joined: 10 Oct 2000 Posts: 656 Location: USA

don't look at the signature, it has not been updating in a long time.

I'm running cmud on vista.

Wizard Joined: 11 Jul 2002 Posts: 1265 Location: USA

I may have been the only one to see that.

Two things.

First, priority no longer exists.

Second, you are using implicit concatenation. Implicit concatenation is frowned upon in CMUD. Don't get me wrong it sometimes works. This just happens to be one of the places it does not.

#VAR @SkillChecks/SkillIncreased %eval( @{%concat("SkillChecks/SkillCountVariables/",@SkillChecks/SkillIncreased)}+1) {_nodef} {SkillChecks|SkillCountVariables}

Should fix the problem once you have also removed the #priority.

Enchanter Joined: 10 Oct 2000 Posts: 656 Location: USA

Thanks for the help.

was priority replaced by anything, any reason why it was dropped?

Wizard Joined: 11 Jul 2002 Posts: 1265 Location: USA

You really should read the changes for Zmud users section of the documentation. priority

Basically, #priority was created as a way to deal with things like #wait and the lack of multi-threading in Zmud.
Cmud has multi-threading and #wait works differently.

The documentation is still a little obscure but it is better than it was back when last you frequented the forums.
There are also places for us to add comments to the help files and those can be helpful too.

SubAdmin Joined: 18 Nov 2001 Posts: 5182

I would also suggest changing these lines

Wizard Joined: 22 Mar 2007 Posts: 2320

Oh my, Talahaski! I wondered where you'd gone. Now I definitely have to get my Dartmud skill tracking package revised and posted on the package library so you can check it out. It should have a number of features you don't have.

Enchanter Joined: 10 Oct 2000 Posts: 656 Location: USA

I've been cleaning this up a lot more.

For anybody following this thread, here is my updated trigger now using local variables.

$SkillIncreased=%subchar(%trim(%1)," -#'>","_____")
#VAR %concat("@",$SkillIncreased) %eval( @{%concat("SkillChecks/SkillCountVariables/",$SkillIncreased)}+1) {_nodef} {SkillChecks|SkillCountVariables}
#Window skills %1 @{%concat("SkillChecks/SkillCountVariables/",$SkillIncreased)}
#Switch (@SkillChecks/PlussOn)
(1) {Qc show skills %1
Qc say + %1
QcCommand}
(2) {Qc show skills %1
QcCommand}
#COLOR 11