Zugg Software :: View topic

Novice Joined: 17 Oct 2002 Posts: 44 Location: USA

I'm setting up an object listing script that grabs the name of objects taken from a corpse and adds it to a list. The script actually looks at the first four words in the object name, checks them against a list of non-keywords ("small", "large", "a", "the", etc), and captures the first viable keyword in the given string. The script as is works okay, but it seems somewhat cumbersome.. and since I have a habit of making things more difficult than they need to be, I thought I'd post what I have and ask for suggestions on making it more efficient / streamlined, if possible.

Posted: Wed Dec 12, 2007 5:19 pm

First off, your %additems won't work because you can't start a command with a function reference. You'll need to put either #CALL or #NOOP in front of it for it to work correctly. Either that, or use obj_list=%additem(%2,@obj_list).

However, for the trigger, why not try it this way?

#TR {^You get (*) corpse of a *.$} {#LOOP 1,4 {#IF (%ismember(%word(%1,%i), @obj_check)) {obj_list=%additem(%word(%1,%i),@obj_list)}}

That should accomplish what you're trying to do. *shrug*

Charneus

EDIT: I made it to where it'll only check the first four words. :P

Novice Joined: 17 Oct 2002 Posts: 44 Location: USA

ehhh.. yeah, about the function reference you're right. I'm scripting at work and my 30 day trial on the zmud I dl'd ran out, so I haven't been able to actually test the code until I can get my reg key from the version I have at home copied over.

As to the improvement.. I appreciate it. That kind of reduction in code is what I was looking for. First 4 should be fine for almost everything except the most inane area builder ("You get an extremely small and sharp green poisoned dagger from the corpse of a wino.") isn't out of the question I suppose Shocked

-JC

SubAdmin Joined: 18 Nov 2001 Posts: 5182

If I understand this you are looking to trigger off of a line like "You get the amazing holographic scepter of imagining from the corpse of a dog." Then you want to take the part "the amazing holographic scepter of imagining" and try to determine a keyword. The way to do this best is first capture the entire thing then eliminate obviously useless words.

Novice Joined: 17 Oct 2002 Posts: 44 Location: USA

Vijilante... I really appreciate the ideas, but they're waaaay over my head. I can more or less follow along with Charneus's example, but yours is way too tech for me. Embarassed

Posted: Wed Dec 12, 2007 9:05 pm

Churlant, Vijilante is that way with everything. His GURU title isn't even appropriate. I wouldn't be surprised if even Zugg is baffled by Viji's know-how. He's a zMUD God, as far as I'm concerned. :P Glad my example works out for you. But later on down the road, you may want to learn to decipher Viji's scripts. He has some VERY good ones, and you can learn a lot. Also, if you need to get it to work for extremely long phrases such as the one you pointed out, you /could/ change the #LOOP 1,4 to #LOOP %numwords(%1) and it'll search the entire thing before corpse. :P Just an idea.

Charneus

Novice Joined: 17 Oct 2002 Posts: 44 Location: USA

I don't doubt Vijilante is genius... but I'm not so sure I'll ever need that level of complexity for anything I'll do in-mud. Hell, I don't even know more than half of the functions/commands he listed. It's like I'm building a soapbox car while he's giving me tutorials on ion propulsion. Laughing

SubAdmin Joined: 18 Nov 2001 Posts: 5182

Probably the only thing new in there is %subchar and %subregex. Also I am most definitely not a god since there script is missing a closing brace, and therefore I have erred. Gods don't make mistakes.

On average I would say the 2 scripts will finish in about the same amount of time. The use of #LOOP doesn't allow for the script to end early, and can cause multiple words to be recorded for a single item. That likely isn't a bad thing. My script, on the other hand, will only record 1 word per item. It may also record none because it requires a list of GoodWords. If you want all words except for the bad ones kept then it becomes even easier.

Posted: Thu Dec 13, 2007 1:21 am

Through talking with Churlant (found out he plays the same MUD as I do), I found out he's needing more than that. The finished code actually looks like this now: