Zugg Software :: View topic

SubAdmin Joined: 18 Nov 2001 Posts: 5182

I was noticing this in 2.08, but wasn't quite sure of what to make of it. Now I am figuring it is caused by having multiple windows with the same name or just a matter of bringing in multiple .muds to a single session. From this picture it looks like 2 tool bars are created for each of the secondary .muds.

The procedure I used to get this was offline opening of my imported session, this converted my main .mud and activated the old onload alarm in it. I disabled the onload alarm so it wouldn't cause trouble then closed CMud. Next launch and offline opening everything looked fine, so I proceeded to add another file. I used the package editor to open the channels.mud file. I again closed CMud, relaunched, and reopened. At this point the toolbar was likely messed up but I hadn't checked. Once again I used File|Open from the PE to bring in the room.mud then closed CMud.

All subsequent launches show messed up commandline positions for the room.mud and channels.mud windows. For a while one window had 2 'comline' and 'histbtn' items showing in the bar. The other window has a comline bar acrossed the middle of the screen with nothing else showing anywhere. I will make a backup of the tbz, just let me know if you want to examine it.

SubAdmin Joined: 18 Nov 2001 Posts: 5182

It looks like this is more of a function of having multiple windows with the same name. When I deleted the orginal .tbz and let a new one be created it still caused a mess. If I remove the maximize from CMud, close it then relaunch and reopen the toolbars come out looking right, but I don't think the maxmized is the problem.

Edit: Holding down shift when opening the session caused them to appear correctly. Close, relaunch, and reopen returned them to a messed up state though.

Posted: Mon Oct 29, 2007 7:21 pm

I'm having a hard time reproducing this one. Have you done a fresh install of 2.09? The reason I ask is that in 2.08 you might have gotten a corrupted preferences in one of your other packages (like your English Directions, or even your Default package).

One bug is that the windows without command lines are not supposed to show the toolbars in the customize menu, so I need to fix that in 2.10. So maybe that is related somehow.

Having multiple windows with the same name shouldn't be causing this problem. Even though the caption of the toolbar has the same name, the underlying toolbar component name adds an additional number to the end if there is a conflict. However, I can see a situation where this number might not match the same window if the order in which the windows is created gets changed somehow. So that might be part of the problem.

I'll see if I can make this a bit more robust so that the toolbars always correspond to the same window no matter how the load order might be changed.

SubAdmin Joined: 18 Nov 2001 Posts: 5182

The bug was generated with a fresh install, the only thing I kept was a backup of the packages, layout, and tbz from 2.08. I did all my various import testing and found a few things, then finally deleted the directory with that testing mess and copied in the good backup from 2.08. So everything listed above was from a fresh install of 2.09 on.

Sadly I forgot about holding on to the bad file, but it would be easy enough for me to get it created again. My examination of it made it appear that some of the toolbars were being recorded as docked within the other toolbars.

I will try to develop a procedure for this that doesn't require an import and starts from a new session.

Posted: Mon Oct 29, 2007 7:56 pm

Hmm, looks like CMUD already names the toolbars with a unique name based upon the unique module Guid. So I'm not seeing how it could confuse the toolbars unless the preferences are messed up for one or more modules.

I *did* discover why all of the toolbars are shown in the right-click menu as being visible even though they aren't. That should be fixed in 2.10.

Also, if you reproduce this, definitely send me the *.tbz file to look at. It's an ASCII file, so it's easy to send via email.

SubAdmin Joined: 18 Nov 2001 Posts: 5182

It looks like the offending section of the toolbar is this.

Posted: Mon Oct 29, 2007 8:28 pm

Reproduced! Thanks for that good procedure.

The entry in the tbz file that you mentioned is actually fine. The DockControl and "DockedDockControl" are supposed to have that value. One part that is wrong is that the caption still says "Session Toolbar 3" instead of "Session Toolbar: test2". So something isn't getting called properly when the window is created from within the Settings Editor vs using the #WINDOW command. And the main problem is that the "Visible=1" is set, which is what is making the command line visible.

Anyway, now that I have a procedure for this, I should be able to get it fixed.

I also noticed that when windows are deleted from the Settings Editor, the toolbar for that window is not getting removed, which is also causing clutter in the tbz file and in the right-click customize menu for the toolbars.

SubAdmin Joined: 18 Nov 2001 Posts: 5182

Another test involving no windows of the same name also caused quite the mess within the file. So names can be ruled out, it looks like it more has to do with The use of the #WINDOW command to make windows, I will try a few other tests with it to see how badly I can mess it up.

SubAdmin Joined: 18 Nov 2001 Posts: 5182

Bah, you posted while I was typing and then I concentrated on other tests and didn't even notice you replied.

One of the things I am seeing from my tests that also relate is that the .tbz gets saved differently depending on which tab is selected when closing. I was noticing that the file changed with just opening the session and closing CMud, without any other interaction with the session. It took me a while to figured out the selected tab makes a difference, and opening the session was changing the selected tab.

When playing with importing my files I also had one of the bars dock inside another bar. This resulted in there being 2 command lines at the bottom of the window. I can't seem to get that to replicate at all, but I can keep trying if you think it is worth it.

Posted: Mon Oct 29, 2007 10:35 pm

Also, don't knock yourself out too much playing with the toolbar system. The Developer Expression Toolbar components underwent a major update last year, and I haven't upgraded to them yet. This is mostly because I have made *so* many changes/fixes to the toolbar system that it will be a major effort to upgrade and then get everything working again. So I've been postponing this until the Delphi 2007 upgrade.

The existing toolbar version that I'm using has been patched a lot and is pretty finicky, so I'm not surprised if there are problems with it. But since upgrading it will potentially fix a lot of issues (and cause a lot of new issues), it's probably not worth a lot of real hard-core testing right now. As long as it works for most people, I'm going to leave it alone until the upgrade.