Zugg Software :: View topic - [2.02] ANSI colour after </send> in #SUB

Wizard Joined: 14 Aug 2004 Posts: 1269

This one took me a surprising length of time to track down before I realised that the text was invisible! Black text on a black background for everything after the </send>. (I tried various combinations of removing the ~ and adding quotes but nothing helped.) (I know the text is there because I can see it if I select the line with mouse.)

Wizard Joined: 25 Mar 2003 Posts: 1113 Location: USA

I would write that #SUB more like this:

Posted: Sat Sep 01, 2007 2:50 pm

The code tag really needs fixing :(

Confirmed - I couldn't find a reliable way to reproduce this offline, but with actual MUD text, it worked... well, didn't work.

Also, a few stylistic notes - you can use %1 instead of &text; to avoid having to quote out that tag if you think that looks ugly (personally, I do). Also, in CMUD the <> characters aren't special and don't need quoting. Finally, you don't need so many captures - you could change the pattern to (%w) ({tells|asks} you '*)$ and then use #sub{<send>%1</send>%2} if you think that looks neater.

Wizard Joined: 14 Aug 2004 Posts: 1269

Thanks for the stylistic tips - some of the reasons it is the way it is, is because I want it to work in zMUD too, and because in actual fact the original script was a quite a lot longer, and the original pattern has another parameter. I simplified it when tracking down this bug.

Posted: Sat Sep 01, 2007 3:56 pm

I've seen this as well. Curious that it doesn't happen offline.

Wizard Joined: 14 Aug 2004 Posts: 1269

Is it even possible to test this offline though? How would you do it? By putting a %ansi into a #SHOW from the command line? I suppose that is not quite the same... And indeed, doing so has the expected, correct, behaviour.

Posted: Mon Sep 03, 2007 5:17 pm

Could someone capture some text that shows this happening using the #DEBUG command so that I can replay it here. Otherwise this is going to be a pain to find.

Wizard Joined: 14 Aug 2004 Posts: 1269

Well, I think this problem is actually caused by something lower down that is also causing this problem: [2.02] %linecol issues

But I did actually capture a #DEBUG if you want it - I didn't know how to name each file though - which one is which? Do you still need it, given this other issue I posted that can be reproduced offline? I quoted the interesting part out of the DEBUG files in my first post anyway.

Posted: Mon Sep 03, 2007 9:26 pm

Yes, still send me both files. The first filename is the one that I can replay. The second filename is the human-readable file that you quoted at the beginning of this post.

What's important about both files is that they show me the actual packet structure so that I can see where the package boundaries are. That can sometimes cause the difference between the live MUD and offline testing.

Wizard Joined: 14 Aug 2004 Posts: 1269

Sent to sales. They both look like plain text to me!

Posted: Mon Sep 03, 2007 11:23 pm

They are, but the first file contains all the control characters as they were received from the MUD - it's the exact text that CMUD saw. The second is human-readable - the control characters are changed into readable text, and the package boundaries are marked more clearly.

Posted: Tue Sep 04, 2007 12:43 am

OK, got the files and I was able to reproduce the problem!

A couple of other notes:

1) Your trigger pattern seems to be missing a ' at the end. I had to use a pattern of

Wizard Joined: 14 Aug 2004 Posts: 1269

Nice!

I guess you worked it out, but the reason I don't have a ' before the $ is in case the MUD wraps the line.