Zugg Software :: View topic - Attempting to convert ZMUD script over to CMUD not successful.

Newbie Joined: 31 Jul 2007 Posts: 5

Perhaps I haven't looked at this closely enough yet, or familiarized myself with the newest changes for CMUD, but every other script I have up and running so far except for this. Likely I am missing large changes in the code change that would allow this to work. Essentially this script keeps track of how long you have left on certain buffs before they run out, and keeps that in a status window. As the buffs tick down they change color from green, to yellow, to red depending on how much time is left. It's a wonderful script and worked beautifully in ZMUD. What am I missing that would allow this to also run in CMUD?

Here is the original ZMUD code.

Posted: Tue Jul 31, 2007 5:41 pm

Did you run the Compatibility Report on this in CMUD? Did it report anything? Without knowing more about what your script is supposed to do, it's hard to help. Nothing obvious jumps out at me (except, like you said, you need to change your & to &&)

Newbie Joined: 31 Jul 2007 Posts: 5

I ran the compatibility test both before I made the changes to || and &&, and after, and both times it came up with no errors found. :( Anyways, here is the script running wonderfully in ZMUD to hopefully give you all a better idea of how nice it is, and exactly what it does.

The trigger runs off when you look at what spells are affecting you, and pulls them up into a status window, so if you are unbuffed it looks like so...

and the window will be

Then as you buff up your character with spells, it pulls up the duration of the buffs into the window when you check them the first time like so...

which pulls it in to look like

It then uses the tick timer, which is set to match the natural tick of the mud, to count down the buff durations without constantly having to check the affects...

Not having it work is a real bummer, and I simply do not have the experience anymore to know how to change it. Any help at all would be greatly appreciated, but I understand if no one can see the problem or has the time to help. I'll live, or just go back to ZMUD, haha.

Quick edit: You'll notice the color changes on the Spell Names in the window. It stays Cyan until the spell has only a few ticks left on it, at which time it turns yellow, when it hits 0, the last tick, it turns Red and then goes into the negative timer to remind you it wore off. After going a few ticks into the negative, it goes back to the regular Dark Red. Anyways, thanks again.

Also, I realize it is a far amount of work, but I am certain that more than a few people would benefit from a script like this. :)

Posted: Tue Jul 31, 2007 11:43 pm

Wow, you sure do like making life difficult for yourself by using a fixed-length stringlist for this. You could use use a data record to keep the data much more easily:

Effects.ProEvil=25
Effects.Armor=25

and then decrement them easily, by name. If you deleted the keys with #delkey after they reach a certain negative value, you could even choose to display only the things that were actually affecting you (which would be made easier with %expanddb).

Really, with that improvement in mind, I'd suggest rewriting the script. You needn't rewrite everything, just the parts that that would change, and then slowly add your functionality back in (like the function to colour the names and durations) until you find something that breaks. It's a lot of work finding tiny bugs in a big script.

That said, you might be best to wait until version 2 of CMUD is released. It's going to include support for real, returning functions and that's probably another feature that your script could really benefit from.

Newbie Joined: 31 Jul 2007 Posts: 5

Unfortunately I am not the original creator of the script. It was made by a friend whom I am no longer in contact with a few years ago. I am fine with simple scripts, but I was hoping for an obvious error on this one that could be quickly fixed to get it back up and working. Since it will obviously take a great amount of work that I cannot do, it looks like I'll either stick with ZMUD, or have to scrap it.

Wizard Joined: 25 Mar 2003 Posts: 1113 Location: USA

Posted: Wed Aug 01, 2007 11:33 am

Ignoring the trigger pattern of doom, is sanctuary even a valid argument for case? I thought it only took numbers :S

Newbie Joined: 31 Jul 2007 Posts: 5

Haha, ya, don't ask me. I'm not entirely sure. I'm just going to forget about it, thanks anyways guys.

Posted: Thu Aug 02, 2007 4:02 am

Alright, here's code that should work for you in CMUD. Besides changing '&' to '&&' which Fang pointed out the main problems were that the status windows not getting picked up properly (notice the curly braces around the Affects_Window function) and that CMUD/zMUD represents functions as variables so when you defined them there were evaluated. So variable/functions like CAff1, Caff2 and Affect_Duration were changed so that they correctly called #FUNC instead of #VAR.

I also went ahead with Fang's recommendation and converted this to use a DB variable. As you can see the code is cleaner and smaller and will probably run faster.

I hope this helps

Newbie Joined: 31 Jul 2007 Posts: 5

Wow, you did some amazing work Tech and I really appreciate. Wasn't expecting this at all. Unfortunately when this was loaded up, the script went crazy and I easily guessed it was that trigger of doom that Fang mentioned.

Posted: Fri Aug 03, 2007 3:31 am

The window should be updating itself automatically as the variable changes. I remember something about that being on the buglist, but I don't remember when - it's possible that it's supposedly fixed.

Wizard Joined: 11 Jul 2002 Posts: 1265 Location: USA

The trigger of doom appears to be an attempt to do some sort of spell-up script that went horribly astray.

Posted: Fri Aug 03, 2007 1:05 pm

That's a pretty naff way of doing that though :|

#exec %item(@Affects_List,7)

And I really can't judge what on earth someone would trigger on the most common letter in the alphabet for. If it's working fine without it, I guess it's not worth worrying about.