Zugg Software :: View topic

Novice Joined: 10 Apr 2003 Posts: 45 Location: USA

...but apparently the changes in the scripting engine between zMUD and cMUD made it stop working.

The last known version of zMUD I remember using was I think 7.21. I had the following script for hunting rats in Achaea:

(I have written the script by hand in the old zMUD format because cMUD requires .xml which adds a lot of unnecessary characters)

#class ratting
#alias {"ratreset"} {@ratgold = 0;@rats = 0;@ratkilled = 0;@rathere = 0}
#alias {"e"} {east;@ratkilled = 0}
#alias {"s"} {south;@ratkilled = 0}
#alias {"n"} {north;@ratkilled = 0}
#alias {"w"} {west;@ratkilled = 0}
#alias {"nw"} {northwest;@ratkilled = 0}
#alias {"ne"} {northeast;@ratkilled = 0}
#alias {"sw"} {southwest;@ratkilled = 0}
#alias {"se"} {southeast;@ratkilled = 0}
#var {"ratgold"} {0} {0}
#var {"rats"} {0} {0}
#var {"rathere"} {0} {0}
#var {"ratkilled"} {0} {0}
#trigger {{A|An}%1rat wanders into view, nosing about for food.} {#math rathere (@rathere + 1)}
#trigger {{A|An}%1rat noses its way cautiously out of the shadows.} {#math rathere (@rathere + 1)}
#trigger {Your eyes are drawn to {a|an}%1rat that darts suddenly into view.} {#math rathere (@rathere + 1)}
#trigger {With a squeak, {a|an}%1rat darts into the room, looking about wildly.} {#math rathere (@rathere + 1)}
#trigger {You have slain {a|an}%1rat} {#math rathere (@rathere - 1);#IF (@rathere < 0) {@rathere = 0};#math ratkilled (@ratkilled + 1);#IF (@ratkilled = 4) {#echo Move on. Rats cleared.}}
#trigger {rat has been slain by} {#math rathere (@rathere - 1);#IF (@rathere < 0) {@rathere = 0};#math ratkilled (@ratkilled + 1);#IF (@ratkilled = 4) {#echo Move on. Rats cleared.}}
#trigger {You detect nothing here by that name.} {#IF (@target = rat) {@rathere = 0}}
#trigger {You cannot see that being here.} {#IF (@target = rat) {@rathere = 0}}
#trigger {Nothing can be seen here by that name.} {#IF (@target = rat) {@rathere = 0}}
#trigger {Ah, I am truly sorry,} {#IF (@target = rat) {@rathere = 0}}
#trigger {With a flick of its small whiskers, {a|an}%1rat dashes out of view.} {#math rathere (@rathere - 1);#IF (@rathere < 0) {@rathere = 0}}
#trigger {{A|An}%1rat wanders back into its warren} {#math rathere (@rathere - 1);#IF (@rathere < 0) {@rathere = 0}}
#trigger {{A|An}%1rat darts into the shadows and disappears.} {#math rathere (@rathere - 1);#IF (@rathere < 0) {@rathere = 0}}
#trigger {Hakhim gibbers insanely and mutters, "Foul vermins! A pox on your ancestors!"} {ratreset}
#trigger {Liirup squeals with delight} {ratreset}
#trigger {The ratman thanks you as you hand over} {ratreset}
#trigger {Jorj smiles out of the unparalysed corner of his face as he accepts} {ratreset}
#trigger {You have slain a baby rat, retrieving the corpse.} {#math ratgold (@ratgold + 7);#math rats (@rats + 1)}
#trigger {You have slain a black rat, retrieving the corpse.} {#math ratgold (@ratgold + 35);#math rats (@rats + 1)}
#trigger {You have slain a rat, retrieving the corpse.} {#math ratgold (@ratgold + 21);#math rats (@rats + 1)}
#trigger {You have slain a young rat, retrieving the corpse.} {#math ratgold (@ratgold + 14);#math rats (@rats + 1)}
#trigger {You have slain an old rat, retrieving the corpse.} {#math ratgold (@ratgold + 28);#math rats (@rats + 1)}

#stat {StatBar1} {rats:@rathere-@ratkilled total:@rats gold:@ratgold}

This class folder is set to be disabled so that its properties remain inactive until another trigger, outside the folder, is received, which enables the folder, as shown:

#trigger {You will now notice the movement of rats. Happy Hunting!} {#cla ratting 1}
#trigger {You will no longer take notice of the movement of rats.} {#cla ratting 0}

So the first trigger activates and enables the class folder and makes its properties active; the second trigger disables the folder and makes the properties inactive again. These two triggers continue to work fine.

The triggers and aliases inside the class folder worked fine in zMUD. However, in cMUD, they don't seem to work. The stat bar doesn't update properly as the values in the variables change, and the directional aliases (n, e, s, w, etc.) produce invalid command messages. This was NOT the case in zMUD which parsed the semicolon basically as an "enter" command so that "e;ode" for example would send the alias "e" and then send the alias "ode" on a separate line. My cMUD does not appear to have a different default setting for the semicolon because if I was to type in two commands manually, on one line and separated by a semicolon, both commands go through properly.

So I'm guessing that the slightly different script engine in cMUD is causing the errors I'm getting in this script, whereas it worked fine under zMUD. Can anyone point out what I need to fix/update? Scripting and script programming is my downfall in computer usage and always will be. Good as I am with computers, and as much as I understand the basic concepts behind programming, I can't write program script well.

Holly

Wizard Joined: 26 Mar 2008 Posts: 1547

Novice Joined: 10 Apr 2003 Posts: 45 Location: USA

Okie, I've made the following adjustments to the script based on your suggestions and in .xml format it now looks like this:

<class name="ratting" initdisable="true" enabled="false">
<alias name="ratreset" autoappend="true">
<value>ratgold = 0;rats = 0;ratkilled = 0;rathere = 0</value>
</alias>
<alias name="e" autoappend="true">
<value>#send "east";ratkilled = 0</value>
</alias>
<alias name="s" autoappend="true">
<value>#send "south";ratkilled = 0</value>
</alias>
<alias name="n" autoappend="true">
<value>#send "north";ratkilled = 0</value>
</alias>
<alias name="w" autoappend="true">
<value>#send "west";ratkilled = 0</value>
</alias>
<alias name="nw" autoappend="true">
<value>#send "northwest";ratkilled = 0</value>
</alias>
<alias name="ne" autoappend="true">
<value>#send "northeast";ratkilled = 0</value>
</alias>
<alias name="sw" autoappend="true">
<value>#send "southwest";ratkilled = 0</value>
</alias>
<alias name="se" autoappend="true">
<value>#send "southeast";ratkilled = 0</value>
</alias>
<var name="ratgold" usedef="true">
<value>0</value>
<default>0</default>
</var>
<var name="rats" usedef="true">
<value>0</value>
<default>0</default>
</var>
<var name="rathere" usedef="true">
<value>0</value>
<default>0</default>
</var>
<var name="ratkilled" usedef="true">
<value>0</value>
<default>0</default>
</var>
<trigger priority="7290">
<pattern>With a squeak, {a|an}%w rat darts into the room, looking about wildly.</pattern>
<value>#add rathere 1</value>
</trigger>
<trigger priority="7400">
<pattern>You have slain a baby rat, retrieving the corpse.</pattern>
<value>#math ratgold (@ratgold + 7);#add rats 1</value>
</trigger>
<stat name="StatBar1" priority="16800">
<value>Rats:@rathere - @ratkilled || Total:@rats || Gold:@ratgold</value>
</stat>
<trigger priority="7180">
<pattern>Hakhim gibbers insanely and mutters, "Foul vermin! A pox on your ancestors!"</pattern>
<value>ratreset</value>
</trigger>
<trigger priority="7190">
<pattern>{A|An} %w rat wanders into view, nosing about for food.</pattern>
<value>#add rathere 1</value>
</trigger>
<trigger priority="7200">
<pattern>{A|An} %w rat noses its way cautiously out of the shadows.</pattern>
<value>#add rathere 1</value>
</trigger>
<trigger priority="7210">
<pattern>Your eyes are drawn to {a|an} %w rat that darts suddenly into view.</pattern>
<value>#add rathere 1</value>
</trigger>
<trigger priority="7270">
<pattern>Liirup squeals with delight</pattern>
<value>ratreset</value>
</trigger>
<trigger priority="7280">
<pattern>You have slain {a|an} %w rat</pattern>
<value>#math rathere (@rathere - 1);#IF (rathere < 0) {rathere = 0};#add ratkilled 1;#IF (ratkilled > 4) {#echo Move on. Rats cleared.}</value>
</trigger>
<trigger priority="7300">
<pattern>rat has been slain by</pattern>
<value>#math rathere (@rathere - 1);#IF (rathere < 0) {rathere = 0};#add ratkilled 1;#IF (ratkilled > 4) {#echo Move on. Rats cleared.}</value>
</trigger>
<trigger priority="7310">
<pattern>With a flick of its small whiskers, {a|an} %w rat dashes out of view.</pattern>
<value>#math rathere (@rathere - 1);#IF (rathere < 0) {rathere = 0}</value>
</trigger>
<trigger priority="7320">
<pattern>You detect nothing here by that name.</pattern>
<value>#IF (target = rat) {rathere = 0}</value>
</trigger>
<trigger priority="7330">
<pattern>You cannot see that being here.</pattern>
<value>#IF (target = rat) {rathere = 0}</value>
</trigger>
<trigger priority="7340">
<pattern>Nothing can be seen here by that name.</pattern>
<value>#IF (target = rat) {rathere = 0}</value>
</trigger>
<trigger priority="7350">
<pattern>Ah, I am truly sorry,</pattern>
<value>#IF (target = rat) {rathere = 0}</value>
</trigger>
<trigger priority="7360">
<pattern>{A|An} %w rat wanders back into its warren</pattern>
<value>#math rathere (@rathere - 1);#IF (rathere < 0) {rathere = 0}</value>
</trigger>
<trigger priority="7370">
<pattern>The ratman thanks you as you hand over</pattern>
<value>ratreset</value>
</trigger>
<trigger priority="7380">
<pattern>{A|An} %w rat darts into the shadows and disappears.</pattern>
<value>#math rathere (@rathere - 1);#IF (rathere < 0) {rathere = 0}</value>
</trigger>
<trigger priority="7390">
<pattern>Jorj smiles out of the unparalysed corner of his face as he accepts</pattern>
<value>ratreset</value>
</trigger>
<trigger priority="7410">
<pattern>You have slain a black rat, retrieving the corpse.</pattern>
<value>#math ratgold (@ratgold + 35);#add rats 1</value>
</trigger>
<trigger priority="7420">
<pattern>You have slain a rat, retrieving the corpse.</pattern>
<value>#math ratgold (@ratgold + 21);#add rats 1</value>
</trigger>
<trigger priority="7430">
<pattern>You have slain a young rat, retrieving the corpse.</pattern>
<value>#math ratgold (@ratgold + 14);#add rats 1</value>
</trigger>
<trigger priority="7440">
<pattern>You have slain an old rat, retrieving the corpse.</pattern>
<value>#math ratgold (@ratgold + 28);#add rats 1</value>
</trigger>
</class>

And the functionality is as follows:

--#send worked like a charm. Thanks.
--Taking out ALL of the @ symbols for the variables didn't work, I figured out where to leave them in.
--The Hakhim trigger didn't fire, but I noticed they finally corrected the typo of "vermins" into the correct spelling "vermin" so I updated the trigger pattern accordingly.
--The ratgold and rats variables came out correct.

--The rathere and ratkilled variables didn't show correctly in the stat bar. I think the reason is as follows:

I am NOT only adding to the rathere variable; therefore I DO have to use the MATH command. Any time I kill a rat, or whenever a rat runs back into its den, the value of the rathere variable goes DOWN by 1. To use the ADD command whenever the variable increases and then the MATH command when it goes down, seems to be the cause of the inconsistency. I will have to change #add rathere 1 back to #math rathere (@rathere+1).

The ratkilled variable should correct itself when the rathere variable is fixed.

I will test this out later in the day and report back with updated results.

Holly

Wizard Joined: 26 Mar 2008 Posts: 1547

Make sure to wrap the XML and any other script posted here in [*code*][/*code*] tags (minus the asterisks) it will give you something like:

Posted: Fri Oct 08, 2010 6:50 pm

You can "add" negative values as well, Holly, so where you have:

#MATH whatever (@var - 1)

You can do:

#ADD @var -1

Charneus

Wizard Joined: 22 Mar 2007 Posts: 2320

Also check the Changes For Zmud Users documents: http://forums.zuggsoft.com/modules/mx_kb/kb.php?page=3&mode=doc&k=2622. All of these things are mentioned there, along with many more.

Novice Joined: 10 Apr 2003 Posts: 45 Location: USA

Call me impatient, I did some more fiddling and figured out where I'd taken out required @ symbols :D

Putting the #MATH command back in made the whole script work properly except for one thing. I'll keep the adding of negative values in mind for my next tweaks.

The one thing that still produces inconsistencies in the rathere variable is the %w in the various patterns such as

GURU Joined: 23 Dec 2000 Posts: 4834 Location: USA

Use a range pattern:

{A|An}[%w%s] rat

Wizard Joined: 26 Mar 2008 Posts: 1547

Yup, that will work to, %s will match any number of spaces OR you can match any number of alpha characters (aka a word), range classes are very useful additions in pattern matching.

Novice Joined: 10 Apr 2003 Posts: 45 Location: USA

When I changd it to

Wizard Joined: 26 Mar 2008 Posts: 1547

I'll take a look at this tomorrow if no one has by then. Sorry about the slow response.

Novice Joined: 10 Apr 2003 Posts: 45 Location: USA

Hehe no rush Chamenas. You've done more than I could ask of anyone here.

An update:

I tried putting the range finder in separate brackets, that is, [%w][%s]. It produced a curious effect. The trigger would fire and increase the rathere variable, ONLY for baby rats. And when said baby rats were allowed to escape unharmed, I got an error message that the trigger fired but didn't compile. Makes me think I'm on the right track but one tiny detail or another is still a monkey wrench in the cogs. I know how utterly unforgiving computer coding can be so this doesn't surprise me. :)

Holly

Posted: Sun Oct 10, 2010 3:58 pm

One minor problem I see is that you're add commands usually look like this

Wizard Joined: 26 Mar 2008 Posts: 1547

I'm getting errors importing the XML. It would likely help if you put all of it into a class and copied and pasted the XML from the class folder so I could import it that way. Classes make everything neater and more organized :)

Novice Joined: 10 Apr 2003 Posts: 45 Location: USA

I took out the space in the -1 modifier. I am also going to try reversing the order of the %w and the %s strings in some of the commands.

The script therefore now looks like this (I did have it in a class before Chamenas, but didn't copy the folder itself, just all the settings inside it, that's why the class and /class tags didn't show :p )

Novice Joined: 10 Apr 2003 Posts: 45 Location: USA

Bingo. Somehow the necessary dividing semicolon was the culprit with the ratkilled variable; it had gotten taken out just before the #IF statement.

The script now appears to work completely on all counts. For those who are interested, here is a copy:

Wizard Joined: 26 Mar 2008 Posts: 1547

Sorry I couldn't help more. It's been a long day, but at least you got it all working, and, hopefully, learned some new stuff in the process. :)