Zugg Software :: View topic

Wanderer Joined: 02 Sep 2005 Posts: 85

It seems that #switch cant process things as fast as they come up, spellups in Aard with saffects (briefdesc for affects) come to mind.. Suggestions on how to improve would be considered.. but this is a general comment, really.. I'm just wondering if large amounts of variable checks affect one #switch statement, this badly..

Posted: Fri Mar 06, 2009 5:06 pm

Well, yeah, if you're trying to run a ton of script very many times very fast it'll cause you problems. I doubt it's anything specifically to do with #switch, but more to do with your use of it. Basically, you'll want to reduce the number of variable calls to as few as possible and use local instead of global variables. You should avoid repeating yourself as much as possible. Some ways of solving a problem will be slower than others, too - like traversing lists, or code that needs to be compiled before it can be run (like with #exec).

This is all general stuff and probably isn't terribly useful for you. If you want specific advice about your script, we really need to see it.

Wanderer Joined: 02 Sep 2005 Posts: 85

I use a variable based spellup (not my code initially); however, I'm thinking it's best if I redo it entirely; the issue is herein, if you have a status window, should you use local or global vars, because that's the only reason I need global

Only three commands are used enough to warrant #switch, as they all (used to/use) #if statements, which is why the main reason I switched to #switch, however, i'm just using one class/trigger (which is on #switch) when I check for saffects, and the variables dont get processed quickly enough, it seems to get skipped over a lot when running said alias.

If you really want the code, I would be more inclined to PM, because the person who shared his original code wanted me to not share it with anyone else, but he's not available, also has not switched over to cmud, so I cant ask him to help here.. Anyway, the point is, there are 75 some-odd, give or take a few, spellup spells that can be casted, and thus a variable check for every one of them run off saffects, which lists all spellups on you currently.. that's a lot of processing for one #switch

Wizard Joined: 22 Mar 2007 Posts: 2320

Are you certain it is just this one trigger that is causing the problem? If you have lots of other triggers, it could also slow things down just trying to match each trigger against each line, when lines come fast from the mud.

Local variables don't exist after the trigger is run, so the status window cannot depend on local variables--it does need global variables.

I'm not sure what you mean by "it seems to get skipped over a lot". What is being skipped over? Nothing should be skipped over, so I guess I don't understand what you mean.

Wanderer Joined: 02 Sep 2005 Posts: 85

In this case, like I said, 75 spells. I have a variable for /most/ if not all spells, if saffects shows a spell as being on, then that variable is changed accordingly. the "skipover" part is due to massive switching, as it were.. from something that could contain up to 40 spells at once to sift through. The triggers arent the issue at all here, however, I do have some that arent updating their respective variables themselves, but that isn't the issue. the issue is some spells are being skipped due to the saffects command being processed too fast.

Wanderer Joined: 02 Sep 2005 Posts: 85

Edit: post edited to move it to a different topic.

Wizard Joined: 22 Mar 2007 Posts: 2320

Better make the question about the mapper a completely separate post, and yet another post about the trigger you think is not firing. Try to keep each post about a single issue.

Wanderer Joined: 02 Sep 2005 Posts: 85

Magician Joined: 17 Apr 2005 Posts: 496

The problem is that in fact you're using a switch statement, and this is how switch statements are designed to work. For example:

Wanderer Joined: 02 Sep 2005 Posts: 85

I converted FROM that.., ah well. :P

Magician Joined: 17 Apr 2005 Posts: 496

Actually, on re-reading, that's probably not the problem.

Have you double checked to make sure the values you're checking against, "Mental barrier" and so on, are correct in your script?

Wanderer Joined: 02 Sep 2005 Posts: 85

Yup, everything is formatted from the original #if's which checked just fine in zmud.

Magician Joined: 17 Apr 2005 Posts: 496

Can you run a few tests?

a) Set up a handful of spells and run your script say, five times. Note which ones it misses each time, and if they're the same ones each time.
b) Unspell or let expire or whatever the ones it -caught correctly- last time. Run the same test again.