Zugg Software :: View topic

Enchanter Joined: 09 Sep 2007 Posts: 605

3 problems with buttons editor dialog:

1) Adding state(s), defining a specific background color for a state and deletion that state results in lost lines in XML view like <state color="black"></state>, which, in turn, causes empty lines shown when clicked on button. If select such a "state", an empty button will be drawn on toolbar with specified background color. In my sample it is black.
If try to delete these lines in XML tab, the Editor deletes... Well, it delete other lines instead, good ones and bad ones. If not just close Editor but click on Save Changes button after deletion of some (not all) states, it cause an error message.
2) If using multistate buttons with more than 2 states, adding new state in the end of list or, at least, after first 2 states often results in first 2 states swap their definitions (colors, captions). After first swap it very rarely repeat this in future, and I didnt find exact conditions at wich this bug occurs again.
3) If adding new state and then drag-drop it in another position in tree view of package editor, this cause change its state number (as it should be), but internally does not change order of lines. Captions for states in editor shown as sorted, but in XML view (and on real button) they are unsorted, while states value still count as 1,2,3 both in Editor and on button regardless what button' caption says. You can attach a variable for states tracking and echo it value with #SAY command while clicking on button.

Think all these problems are due to wrong indexes of lines that CMUD track internally and can be easy fixed.

3) Not a bug but rather an inconsistance. While states number in editor starts from 0, variable that recieve button state, has minimum value of 1. Making both of them zero-based or 1-based will make scripts more easy to read and understand.

4) The buttons lack the ability to change foreground color. Switching background color can make button text hard to read and there is no many colors to choose from if foreground color fixed.

Posted: Sun Sep 16, 2007 6:57 pm

For number 4 for you can change the button text color. This is specified on the main button definition and not one of the states. In other you can modify button text color the same place you specify it's toolbar and position.

Enchanter Joined: 09 Sep 2007 Posts: 605

2 Tech

I wrote number 4 with zMUD in mind, where I can have color-specific _states_ for _each_ button on the same toolbar. I use this for spells control with toggle buttons. Black on gray = inactive spell, green on black + pushed = active spell. In CMUD I forced to use status window for this, in addition to its own content. This make status window overburdened with information.
In any way number 4 is NOT a bug, just my thoughts.

Enchanter Joined: 11 Feb 2003 Posts: 511 Location: USA

Hmm, Tech is actually stating what I normally see used even in zMUD for what you are talking about. Since you are only using two states, you don't really need a multistate button, you only need to use a #noop on the button to change the colors.

Enchanter Joined: 09 Sep 2007 Posts: 605

Tech point that I can change text color - yes, but it stay the same for any of 2 states of toggle button. I can change background color for each state (pushed/unpushed), but why I cant do the same thing for text? As I said black-on-gray/green-on-black. Now I can select either black either green.

Actually, I have push, toggle, multistate buttons... Think twice before select most suitable type. Smile

Would like to see a command to change colors programmatically. They (colors) even no need to be saved in settings.

Smile

Wanna first those bugs get fixed.

Posted: Mon Sep 24, 2007 8:33 pm

1) Still trying to reproduce this. Can you give the exact steps you used to cause this to happen. Pay particular attention to when the XML tab was selected when doing other things. You should make sure to create button states when the XML tab is NOT selected.

2) Cannot reproduce this yet

3) I'll fix the display in the settings editor to start at 1 instead of 0. State 0 really refers to the main button definition.

4) I'll add this to the wish list for the future. The current settings only store the background color for button states.

Enchanter Joined: 09 Sep 2007 Posts: 605

1) I've find that actually editor save changes, but require reload session in order for changes to take effect.
Create a multistate button, add some states (for ex., 4), name them (Captions) State 0, State 1, State 2, State 3. Try to delete any state from tree view. Close editor. Click on button - it still shows 4 menu items. You need to close session and open it again to get this button without deleted states.

2) It is strange, but now I can't reproduce it myself! Just made 7 buttons, only once I have described behavior, but after that can't repeat 5 times in a row! Ok, I'll try to find out what exactly cause reported bug...