Zugg Software :: View topic

Adept Joined: 18 Jun 2019 Posts: 279

If anyone can see why the nested switch statements are not being tested, I'd appreciate it. I cannot see anything amiss.

I inserted some write statements and the outer SWITCH is being tested fine. I am certain I have used such a structure in the past.

Adept Joined: 18 Jun 2019 Posts: 279

In the cold light of day, and minus the copious amount of vodka I consumed, I spotted that i left '=' out of a bunch of assignments.

However, even after correcting this, inside switches are still being ignored.

I have also tried

(eg)

Posted: Mon May 10, 2021 7:43 pm

Nested switches do work:

$a=1
$b=2
#SWITCH ($a) (1) {#SWITCH ($b) (2) {#SAY hi}}

As far as the error in your script... did you try using the syntax checker? it might be able to find it for you.
ctrl +k is the shortcut, or you can select it from the editor menu of the settings editor

Adept Joined: 18 Jun 2019 Posts: 279

Syntax check raised no errors.

Incidentally, a couple of weeks ago I had to also modify this:

#IF ($charLev<20) {cast 'cure critical';#EXIT}
#IF ($charLev>=20) {cast 'heal'}

as it would not work written as:

#IF ($charLev<20) {cast 'cure critical'} {cast 'heal'}

I have checked the state of $charLev and it DOES have a value. I also tried using the permanent version, AND using a set figure (in this case 73) but the inner SWITCHes are just not playing ball despite all variations producing the same figure.

Adept Joined: 18 Jun 2019 Posts: 279

I tried using IF instead of the nested switch. Problem now is that #BREAK or #EXIT will end the entire script, anything else just runs through all the remaining IF, executing each one in turn and thereby changing the potion matching a character level for a higher level potion...which cannot be used.

It is going to be messy to have to fully quantify every IF

#IF (($charLev>1) AND ($charLev<20) {}
etc

UPDATE:

Posted: Tue May 11, 2021 11:08 am

This might be a situation where a dbVar comes in handy.

#LOCAL $this
$pot=%db(@potions, %1)
#FORALL %dbkeys($pot) {#IF (($charLev >= %i) AND ($charLev <= %db(%db($pot, %i), Max)) {$this=%db($pot, %i}}
#WALK %roomkey(%db($this, Shop))
etc

Adept Joined: 18 Jun 2019 Posts: 279

I tried something similar initially...ran into problems trying to sort out logic for:

if I already have a batch of potions at a previous level, continue using those

...and it also started to get a bit logically messy.

Posted: Tue May 11, 2021 11:30 am

It would likely be easier to fix that than the nested switch scenario (especially given that syntactically it should work already.)

GURU Joined: 10 Oct 2000 Posts: 873 Location: USA

This seems like what the database is for.

You're trying to search for a value by two fields (category like "arm" or "invis" and level).

Could you make a table with those values and then use %query to get the matching record?

You might need a min level and max level column for each row to make it easy.

http://forums.zuggsoft.com/modules/mx_kb/kb.php?page=3&mode=doc&k=2348

Adept Joined: 18 Jun 2019 Posts: 279

We avoid the databases as that is not a completely useful module.

Using dbvars also has it's downside in that I am also using the lookups to populate buttons which is best done with proper vars. Furthermore, I already had a dbvar looking like:

bls="7="keyword=prayer|shop=32476"|15="keyword=blessing|shop=32172"|25="keyword=special|shop=26275"|57="keyword=embrace|shop=32408""

but I could NOT make it cough up the proper sub-key pair for love nor money.

In the end I simplified the entire thing by splitting each potion out to its own var

eg.,

blsPotTbl

1=data
10=data
35=data

and just looped around inside it with @{%1PotTbl}.%i.key

and dropped the data into button-use variables

So client is currently is happy with

forall
if

but not

switch
switch

or

switch
if

GURU Joined: 10 Oct 2000 Posts: 873 Location: USA