Zugg Software :: View topic - Some Regex help assistance-

Beginner Joined: 15 Jun 2007 Posts: 17

This is my first shot at a regex, so yeah...
I am using this pattern

Magician Joined: 28 Jan 2007 Posts: 430

Beginner Joined: 15 Jun 2007 Posts: 17

So, and I know it probably has a ton of errors the non regex eye such as mine doesn't spot, is my pattern alright then?

Posted: Tue May 13, 2008 2:14 am

Well, it seems to be some kind of mutant child of regex and zScript. You've got the %w and the {one|two} syntax from zScript and the ? meaning "optional" from regex. That and you're using %w for an item that could potentially be more than one word and also contain hyphens (the number). And you've got optional stuff all over the place, including inside other optional stuff you don't really need. So no, it probably won't work. It might be easier to do:

^There is a total of ([\w\- ]+) (gold|silver|copper)(?:, ([\w\- ]+) (silver|copper))?(?: and ([\w\- ]+) (silver|copper))? coins$

However, while all of the patterns match, some ("There is a total of one gold, eight silver and two copper coins") capture incorrectly, giving %3 as "eight silver and two". I'm not sure what can be done about that.

Beginner Joined: 15 Jun 2007 Posts: 17

Oh, I was somehow thinking they could be used together, and there aren't any hyphenated words in any of the examples I had provided....so not sure where you're getting the hyphen from.

Posted: Tue May 13, 2008 3:44 pm

Because if there are more than twenty coins, there's going to be a hyphen. There are twenty-eight gold coins. The GetNum function you're using assumes that the number will use hyphens.

Beginner Joined: 15 Jun 2007 Posts: 17

Well..., I hadn't realized the thing about the hyphens but I do see it in the function now. But, none of them numbers will be above 10. IE-10 copper=1 silver, 10 silver=1 gold, and there definitely won't ever be any more then 5 gold at a time. Maybe that helps a bit?

Wanderer Joined: 03 Feb 2007 Posts: 64

I did this on one mud (before zmud had regex) and since I am still not great at regex, I just made a trigger for each possible combination....

There is a total of (%w) gold coins.
doTax %1 0 0

There is a total of (%w) silver coins.
doTax 0 %1 0

There is a total of (%w) copper coins.
doTax 0 0 %1

There is a total of (%w) gold, (%w) silver and (%w) copper coins.
doTax %1 %2 %3

There is a total of (%w) gold and (%w) silver coins.
doTax %1 %2 0

There is a total of (%w) gold and (%w) copper coins.
doTax %1 0 %2

There is a total of (%w) silver and (%w) copper coins.
doTax 0 %1 %2

Then I would make an alias that accepts 3 params (gp,sp,cp)
alias

doTax
#if ((@getnum(%1)!=0)) {totaltax=%eval(@totaltax+(@getnum(%1))}
#if ((@getnum(%2)!=0)) {totaltax=%eval(@totaltax+(@getnum(%2))}
#if ((@getnum(%3)!=0)) {totaltax=%eval(@totaltax+(@getnum(%3))}

But, how are you calculating the tax for copper vs gold, should we do like...

doTax
#if ((@getnum(%1)!=0)) {totaltax=%eval(@totaltax+(@getnum(%1))}
#if ((@getnum(%2)!=0)) {totaltax=%eval(@totaltax+(@getnum(%2)/10)}
#if ((@getnum(%3)!=0)) {totaltax=%eval(@totaltax+(@getnum(%3)/100)}

(showing tax in gp and decimals for sp/cp)
Of course reverse the math if you want tax in cp, (multiply gp*100, sp*10)

Beginner Joined: 15 Jun 2007 Posts: 17

I was kind of hoping to avoid all of the different triggers, which is why I had (badly) attempted to make a regex with optional items.

Posted: Tue May 20, 2008 3:11 am

Well, my regex works, you'll just have to be careful about checking the parameters for the phrase "silver and" and splitting it in two if it's present.